Django

Code

Ticket #1235 (closed: fixed)

Opened 3 years ago

Last modified 2 years ago

[patch] [magic-removal] Django can''t send e-mail in other encoding than ''us-ascii''

Reported by: igor@goryachev.org Assigned to: adrian
Milestone: Component: Core framework
Version: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

I think it would be very useful if it was possible to send e-mail (using 'django.core.mail') in something different than 'us-ascii', for example, in 'utf-8' by default (using DEFAULT_CHARSET variable).

The patch will be included.

Attachments

django-mail-charset-support.diff (1.2 kB) - added by igor@goryachev.org on 01/16/06 07:19:22.
patch for support different charsets in mail messages
django-mail-charset-support.2.diff (1.1 kB) - added by akaihola on 02/28/06 16:17:22.
magic-removalized version of the patch, with Header() import

Change History

01/16/06 07:19:22 changed by igor@goryachev.org

  • attachment django-mail-charset-support.diff added.

patch for support different charsets in mail messages

01/16/06 07:30:13 changed by hugo

what is this Header() call you are using? Shouldn't it be imported from somewhere (or defined somehow)? Can't find it in the core/mail.py or in your patch.

01/16/06 07:33:04 changed by igor@goryachev.org

Arhhh. Very sorry.

Forgot to include importion of email.Header.Header: 

from email.Header import Header

01/16/06 08:50:51 changed by hugo

Ok. That one does handle quoted-printable-encoding correctly, so I am +1 on this patch.

02/28/06 08:16:22 changed by alex.smudgy@gmail.com

And when can we wait for patch in django-release ?

02/28/06 16:17:22 changed by akaihola

  • attachment django-mail-charset-support.2.diff added.

magic-removalized version of the patch, with Header() import

02/28/06 16:18:45 changed by akaihola <antti.kaihola@linux-aktivaattori.org>

  • summary changed from Django can't send e-mail in other encoding than 'us-ascii' to [patch] [magic-removal] Django can't send e-mail in other encoding than 'us-ascii'.

04/14/06 14:32:28 changed by adrian

  • priority changed from normal to low.
  • severity changed from normal to minor.

04/29/06 04:08:50 changed by igor@goryachev.org

Adrian, why is it a minor/low issue? Please believe me it is very important for people who use not only latin1 charset (i.e. Russians).

When this patch will appear in the mainstream?

Thank you.

05/13/06 02:53:06 changed by dottedmag@dottedmag.net

I also don't think that ignoring everyone except English-speaking people is the 'minor' issue with 'low' priority. It's even not Latin1 charset which would be ok for some europeans, it is US-ASCII, which is sufficient only for English.

05/13/06 02:58:20 changed by unatine@gmail.com

When this patch appear in trunk? It's very important for non-English speaking users.

05/13/06 03:06:12 changed by timochka@gmail.com

I want messages in UTF-8! I'm +1 for this patch

05/13/06 04:38:24 changed by mblsha

It would be cool to support unicode when sending mail, so Django would be on par with Rails in this case.

05/13/06 12:10:38 changed by jacob

What, did you guys organize a write-in campaign or something? :)

05/13/06 12:18:47 changed by jacob

  • status changed from new to closed.
  • resolution set to fixed.

(In [2901]) Fixed #1235: email sent from django.core.mail will now be encoded using the value of the DEFAULT_CHARSET setting. Thanks, igor@goryachev.org and akaihola.

06/14/06 08:25:02 changed by anonymous

  • summary changed from [patch] [magic-removal] Django can't send e-mail in other encoding than 'us-ascii' to [patch] [magic-removal] Django can''t send e-mail in other encoding than ''us-ascii''.

Add/Change #1235 ([patch] [magic-removal] Django can''t send e-mail in other encoding than ''us-ascii'')




Change Properties
Action