Django

Code

Ticket #1634 (closed: fixed)

Opened 3 years ago

Last modified 2 years ago

[patch] core.mail does not include a Date header in mails

Reported by: Russell Cloran <russell@hbd.com> Assigned to: adrian
Milestone: Component: Validators
Version: new-admin Keywords:
Cc: Triage Stage: Unreviewed
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

Hi,

core.mail does not include a "Date" header, leading to mails which land up right at the bottom of my mailbox, which is a bit irritating :)

I can't think of any reason why anybody would want to generate an email without a Date header? 

Index: django/core/mail.py
===================================================================
--- django/core/mail.py (revision 2694)
+++ django/core/mail.py (working copy)
@@ -3,6 +3,7 @@
 from django.conf import settings
 from email.MIMEText import MIMEText
 import smtplib
+import time

 class BadHeaderError(ValueError):
     pass
@@ -46,6 +47,7 @@
         msg['Subject'] = subject
         msg['From'] = from_email
         msg['To'] = ', '.join(recipient_list)
+        msg['Date'] = time.strftime('%a, %d %b %Y %H:%M:%S %z')
         try:
             server.sendmail(from_email, recipient_list, msg.as_string())
             num_sent += 1

Attachments

django_core_mail.diff (0.7 kB) - added by eric@ericwalstad.com on 05/25/06 00:49:53.
Patch to add RFC 822 Date header to send_mail function

Change History

04/13/06 08:14:16 changed by adrian

Hmm, all the e-mails sent out by django.core.mail in my experience have *had* date headers. Is this something the e-mail server takes care of, and some servers don't do it? I believe I've always used sendmail.

05/09/06 10:54:19 changed by adrian

  • status changed from new to closed.
  • resolution set to worksforme.

Closing for the reason outlined in the comment above. Please reopen if you have a good argument for adding Date headers.

05/25/06 00:48:21 changed by eric@ericwalstad.com

  • priority changed from normal to low.
  • status changed from closed to reopened.
  • version changed from magic-removal to SVN.
  • resolution deleted.

I get the same problem on debian sarge, python2.3.

Mail sent from my hosting provider's RHEL box does include a Date: header. I suspect the date header is being added by some systems but not others.

Adrian, won't you please help us poor sods who's systems don't add a date header by default?

I'll buy you a beer and/or take you sailing next time you are in San Francisco :) (Ok, I'll do that whether you use this patch or not)

This approach uses the rfc822 module: 

>>> import rfc822
>>> rfc822.formatdate()
'Thu, 25 May 2006 05:40:36 GMT'

See attached patch file

05/25/06 00:49:53 changed by eric@ericwalstad.com

  • attachment django_core_mail.diff added.

Patch to add RFC 822 Date header to send_mail function

05/25/06 23:39:46 changed by adrian

Oooh, sailing in San Francisco!

05/25/06 23:40:49 changed by adrian

  • status changed from reopened to closed.
  • resolution set to fixed.

(In [2984]) Fixed #1634 -- Changed django.core.mail to include 'Date' header in e-mails. Thanks, Eric Walstad

07/03/06 02:11:55 changed by anonymous

  • severity changed from normal to blocker.
  • component changed from Core framework to Validators.
  • priority changed from low to high.
  • version changed from SVN to new-admin.
  • milestone set to Version 0.91.
  • type changed from defect to task.

10/24/06 15:17:18 changed by adrian

  • milestone deleted.

Milestone Version 0.91 deleted

Add/Change #1634 ([patch] core.mail does not include a Date header in mails)




Change Properties
Action