Django

Code

Ticket #2437 (closed: fixed)

Opened 2 years ago

Last modified 1 year ago

[patch] Quick Copy to pastebin

Reported by: dummy@habmalnefrage.de Assigned to: ekarulf
Milestone: Component: Uncategorized
Version: SVN Keywords: pastebin, sprintsept14, sprintdec1
Cc: erik@karulf.com Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 1

Description

Hi,

I read that there is an "little, easy improvements" open. Since the owner was 'just starting' I tried it myself and thought that it wasn't really difficult to solve.

Regards, Dirk

Attachments

debug-pastebin.patch (1.1 kB) - added by dummy@habmalnefrage.de on 07/27/06 12:06:37.
Quick Copy to pastebin
django_dpaste.diff (1.6 kB) - added by Simon G. <dev@simon.net.nz> on 04/03/07 07:06:27.
django_dpaste-2.diff (3.1 kB) - added by ekarulf on 12/01/07 12:48:06.
Updated to include some extra environment information
django-dpaste-prettified.diff (3.4 kB) - added by xian on 12/01/07 14:20:56.
django-dpaste-prettified-2.diff (4.5 kB) - added by ekarulf on 12/01/07 17:35:44.
Updated the prettified code per some recommendations from fellow sprinters

Change History

07/27/06 12:06:37 changed by dummy@habmalnefrage.de

  • attachment debug-pastebin.patch added.

Quick Copy to pastebin

07/27/06 12:23:49 changed by adrian

Very cool. I think we'll set up a pastebin on djangoproject.com, and point this patch at it, rather than relying on pastebin.com, because pastebin.com has been flaky lately.

07/27/06 13:11:43 changed by anonymous

  • summary changed from Quick Copy to pastebin to [patch] Quick Copy to pastebin.

10/11/06 03:27:44 changed by Chris Rose <chris@vault5.com>

Its worth noting that the source for pastebin.com is GPL and can be obtained from http://pastebin.com/pastebin.tar.gz, however I suspect any tool used on the djangoproject.com site will be developed with Django :p

10/23/06 12:02:11 changed by Marek Kubica

The pastebin at paste.e-scribe.com is in fact written in Python using Django (source available) and highlights all kinds of Django-related code like Python, Python-Transcripts (interactive Python) and Django-templates. Quite nice.

(follow-up: ↓ 6 ) 01/18/07 03:15:01 changed by Simon G. <dev@simon.net.nz>

  • keywords set to pastebin.
  • owner changed from adrian to jacob.
  • component changed from Admin interface to Uncategorized.
  • stage changed from Unreviewed to Accepted.

This has been in the Quick Easy improvements page in the wiki for years.

(in reply to: ↑ 5 ) 03/21/07 18:35:36 changed by Marc Fargas <telenieko@telenieko.com>

Replying to Simon G. <dev@simon.net.nz>:

This has been in the Quick Easy improvements page in the wiki for years.

And it's on it's way to be "Accepted" for years! :P If the patch is ok, why isn't it "Ready for checkin" ?

On the other side, I'd rather place a big box telling that pressing the button you're about to publish your traceback on a public site ;)

03/21/07 19:16:54 changed by adrian

The reason we're waiting on this is because the patch uses pastebin.com, whereas it should use Django's custom pastebin (or maybe dpaste). Django doesn't have a custom pastebin on djangoproject.com, but we might be able to use dpaste.com if Paul B. is willing to commit to maintaining it.

03/29/07 09:56:27 changed by Paul Bx <pb@e-scribe.com>

Sorry for the lag. Simon G and I have now exchanged email about this -- consider me commited.

04/03/07 07:06:27 changed by Simon G. <dev@simon.net.nz>

  • attachment django_dpaste.diff added.

04/03/07 07:13:55 changed by Simon G. <dev@simon.net.nz>

I've attached a patch which modifies the original from dummy (at) habmalnefrage.de to use dpaste. Note that this also escapes a few other values in debug.py that should be escaped.

@ Paul Bx: I've added a a "source" parameter which you can use to track stats.

09/15/07 08:46:56 changed by Fredrik Lundh <fredrik@pythonware.com>

  • keywords changed from pastebin to pastebin, sprintsept14.
  • stage changed from Accepted to Ready for checkin.

10/20/07 08:55:13 changed by mtredinnick

  • needs_better_patch set to 1.
  • stage changed from Ready for checkin to Accepted.

I was this close to committing this, but then I tried it out first. Unfortunately, it's not very visually appealing. On Firefox, at least, the button gets a bit lost in amongst all the traceback text.

We also probably need a short (one sentence?) description of what will happen when you push the button. Something like "this will send the traceback to a public website so you can share it with others. You will have a chance to confirm the paste before it is made public" -- but use better wording. I agree with Marc Fargas that some explanation is probably necessary.

However, making it look less crushed together is the real priority here. We always win "prettiest debug page" at the country fair and adding this would hurt our chances. Apart from that, it's good.

11/29/07 22:57:59 changed by ekarulf

  • cc set to erik@karulf.com.
  • keywords changed from pastebin, sprintsept14 to pastebin, sprintsept14, sprintnov29.
  • status changed from new to assigned.
  • owner changed from nobody to ekarulf.

Assuming Fredrik/Simon doesn't mind, I'll pretty this up at the November 29th sprint.

12/01/07 12:48:06 changed by ekarulf

  • attachment django_dpaste-2.diff added.

Updated to include some extra environment information

12/01/07 12:51:47 changed by ekarulf

  • keywords changed from pastebin, sprintsept14, sprintnov29 to pastebin, sprintsept14, sprintdec1.

The patch also removes some extraneous text (per Jacob's recommended)

12/01/07 14:20:56 changed by xian

  • attachment django-dpaste-prettified.diff added.

12/01/07 14:22:53 changed by xian

django-dpaste-prettified.diff is up and it prettifies everything and fixes some usability/extra code bits in the earlier patches.

12/01/07 14:24:03 changed by jacob

  • stage changed from Accepted to Ready for checkin.

12/01/07 17:35:44 changed by ekarulf

  • attachment django-dpaste-prettified-2.diff added.

Updated the prettified code per some recommendations from fellow sprinters

12/01/07 18:00:36 changed by mtredinnick

  • status changed from assigned to closed.
  • resolution set to fixed.

(In [6820]) Fixed #2437, #6091 -- Added "paste to dpaste" button to debug page. Thanks, Christian Metts, Erik Karulf, Simon Greenhill, dummy@habmalnefrage.de.

Add/Change #2437 ([patch] Quick Copy to pastebin)




Change Properties
Action