Django

Code

Ticket #3546 (closed: invalid)

Opened 2 years ago

Last modified 2 years ago

Add timestamp and user for edits to Comment/FreeComment in contrib.comments

Reported by: byteflood@yahoo.com Assigned to: adrian
Milestone: 1.0 beta Component: django.contrib.comments
Version: SVN Keywords: comments, moderation, contrib, edit
Cc: Triage Stage: Design decision needed
Has patch: 0 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

In benchmarking Django's contrib.comments implementation against other frameworks that offer site-wide comments, there are subtle variations in the model used to represent the actual comments. Django's comments provide for some valuable extensions, but seem to be missing something that many other implementations have: fields for the user that last edited a comment and the time at which that edit was made.

This actually seems a bit odd since care was taken with ModeratorDeletion? to provide for a record of removal of given comment. However, cases when a moderator would prefer to edit the comment instead of marking it deleted.

Proposal is to add the eqivalent of edit_date and edit_user to the comments implementation. This seems to be a common pattern in models offering similar functionality.

Attachments

Change History

02/21/07 18:15:05 changed by Simon G. <dev@simon.net.nz>

  • needs_better_patch changed.
  • stage changed from Unreviewed to Design decision needed.
  • needs_tests changed.
  • needs_docs changed.

The comments app will be rewritten prior to 1.0, so I've marked this as Design Decision needed.

02/21/07 19:33:04 changed by ubernostrum

  • status changed from new to closed.
  • resolution set to invalid.

Actually, the goal of the comments rewrite is such that you'll hopefully be able to add in anything you need or want, so I'm going to close this as invalid for now -- we'll revisit this when the comments rewrite comes up (which will be sometime after the 0.96 release).

02/21/07 23:25:31 changed by Simon G. <dev@simon.net.nz>

Ok, I've listed all the comments requests that I can find on FeatureGrouping to help the rewriter (Jacob?) to track down what's valid or not.

Add/Change #3546 (Add timestamp and user for edits to Comment/FreeComment in contrib.comments)




Change Properties
Action