Django

Code

Ticket #8651 (closed: fixed)

Opened 4 months ago

Last modified 4 months ago

Deserializer does not allow for 0 based primary keys on a foreign keyed table

Reported by: chesnutd Assigned to: jacob
Milestone: 1.0 Component: Uncategorized
Version: SVN Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: 1 Needs documentation: 0
Needs tests: 0 Patch needs improvement: 0

Description

The deserializer in core/serializers/python does not take into account that you can have a foreign key values of zero. The statement:

if field_value:

It should be changed to

if field_value is not None:

I've included that patch

Attachments

core_seralizers_python_patch.diff (0.5 kB) - added by chesnutd on 08/28/08 13:08:13.
deserializer patch

Change History

08/28/08 13:08:13 changed by chesnutd

  • attachment core_seralizers_python_patch.diff added.

deserializer patch

08/28/08 13:27:05 changed by mtredinnick

  • needs_better_patch changed.
  • needs_docs changed.
  • stage changed from Unreviewed to Accepted.
  • needs_tests changed.
  • milestone set to 1.0.

08/28/08 14:07:19 changed by jacob

  • owner changed from nobody to jacob.
  • status changed from new to assigned.
  • stage changed from Accepted to Ready for checkin.

08/28/08 14:42:05 changed by jacob

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed in [8676].

Add/Change #8651 (Deserializer does not allow for 0 based primary keys on a foreign keyed table)




Change Properties
Action